Rename s1 photon hits output #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Pull Request Test Coverage Report for Build 8890906133Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 8890899949Details
💛 - Coveralls |
ramirezdiego
approved these changes
Apr 30, 2024
zihaoxu98
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit this PR: make sure to put all XENONnT specific information in a wiki-note as the repo is publicly accessible
What does the code in this PR do / what does it improve?
This PR renames the output of the
S1PhotonHitsplugin from"s1_photons"to"s1_photon_hits"to avoid confusion with the dtype of the propagated s1 photons.Please include the following if applicable: